Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export cleanup - pass processor object rather than the query object #12485

Merged
merged 2 commits into from
Jul 17, 2018

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Export class cleanup

Before

$query object passed around

After

$processor object passed around

Technical Details

The processor object is the class we are migrating the Export functionality to - in a cleaned up manner. A lot of the work on the export class lends itself much better to an OOO class (& cleanly defined functions in a sensible order!). Later refactors will move the functions from which the processor is used onto the processor class itself

Comments

@jitendrapurohit if you can

@civibot
Copy link

civibot bot commented Jul 16, 2018

(Standard links)

Copy link
Contributor

@jitendrapurohit jitendrapurohit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manually tested the export process for different components. It seems to be working well without any issues. Could be merged 👍

@eileenmcnaughton eileenmcnaughton merged commit 4e05c83 into civicrm:master Jul 17, 2018
@eileenmcnaughton eileenmcnaughton deleted the queryFields branch July 17, 2018 10:53
@eileenmcnaughton
Copy link
Contributor Author

thanks @jitendrapurohit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants