Export code tidy up Use queryFields rather than query. Look to stop passing around query. #12484
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Minor code tidyup
Before
No change
After
No change
Technical Details
I'm using the variable $queryFields instead of $query->_fields in a few places. This is really preparatory to not passing around $query since that's a complex object where we only need one piece of data from it. I will be passing $processor in another PR - allowing the values to be retrieved using a getter - see 96f1a0a
Comments