Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export code tidy up Use queryFields rather than query. Look to stop passing around query. #12484

Merged
merged 1 commit into from
Jul 16, 2018

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Jul 16, 2018

Overview

Minor code tidyup

Before

No change

After

No change

Technical Details

I'm using the variable $queryFields instead of $query->_fields in a few places. This is really preparatory to not passing around $query since that's a complex object where we only need one piece of data from it. I will be passing $processor in another PR - allowing the values to be retrieved using a getter - see 96f1a0a

Comments

@civibot
Copy link

civibot bot commented Jul 16, 2018

(Standard links)

@eileenmcnaughton eileenmcnaughton merged commit 07cdb0a into civicrm:master Jul 16, 2018
@eileenmcnaughton eileenmcnaughton deleted the queryFields branch July 16, 2018 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants