NFC cleanup to financial classes

[mattwire]

Overview

Just a quick cleanup of a few comments / unused variables.

Before

more messy code

After

less messy code

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

these all make sense

[eileenmcnaughton]

test fail is odd but it's hard to see how it can related

CRM_Contribute_BAO_ContributionTest::testcreateProportionalFinancialEntries
Exception: PEAR_Exception: "DB Error: already exists"
 * ERROR TYPE: DB_Error
 * ERROR CODE: -5
 * ERROR MESSAGE: DB Error: already exists
 * ERROR MODE: 16
 * ERROR USERINFO: INSERT INTO civicrm_financial_account

[eileenmcnaughton]

test this please

[colemanw]

@civicrm-builder retest this please

[eileenmcnaughton]

This fail relates to another PR merged today (@colemanw that activity report one - the test green tick was from before this test was added)

merging