Rename CRM_Contribute_BAO_ManagePremiums to CRM_Contribute_BAO_Product and deprecate CRM_Contribute_BAO_ManagePremiums

[mattwire]

Overview

Ref #12435 @eileenmcnaughton as discussed.

Before

CRM_Contribute_BAO_ManagePremiums extends from CRM_Contribute_DAO_Product and is actually the BAO_Product class but has a different name (so the API doesn't use it and any other DAO/BAO magic does not pick it up). Also, it's really confusing when working with that code!

After

CRM_Contribute_BAO_ManagePremiums is deprecated (and extends from the new CRM_Contribute_BAO_Product class).
The CRM_Contribute_BAO_Product class is a renamed copy of the CRM_Contribute_BAO_ManagePremiums class.

Technical Details

BAO object named properly for Product entity.

Comments

The "Premiums" code has not been touched for around 5 years so I don't think it is used very often!

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

I went through the same refactor process locally & agree with these changes

I had some concerns about the seemingly additional change in there to stop overwriting on update but I now understand that the reason is that the standardisation of the BAO caused it to be newly picked up by the product api & hence tested via the syntaxconformance test - which meant that to keep parity the overwrites had to be fixed in the same PR