dev/core#259 OptionGroup Admin UI workflow improvements

[mattwire]

Overview

Ref: https://lab.civicrm.org/dev/core/issues/259

Various improvements to the "flow" of the option groups admin pages.

Before

• No option to edit option group settings (eg. change the label).
• When clicking "Done" editing options, redirect to the option groups list instead of the default admin page.

After

• Add option to edit option group settings (the code was already in place, but not exposed in UI).
  • Display "is_reserved" status on option group settings.
  • Don't allow changing data type on reserved option groups.
  • On update optiongroup don't touch is_reserved.
    

• When clicking "Done" editing options, redirect to the option groups list instead of the default admin page.
  

Technical Details

UI only changes that enable editing option groups parameters.

Comments

If you are working with multiple option groups, the UI has always been a bit difficult to navigate and various functions are not possible via the UI (such as changing the label of an option group).

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

@mattwire does this need a rebase now?

[mattwire]

@eileenmcnaughton Thanks, now rebased.

[colemanw]

@mattwire any idea what setting the "data type" on an option group actually does? The column in sql is varchar no matter what.

[colemanw]

• (r-jira) Pass
• (r-test) Pass
• (r-code) Pass
• (r-doc) Pass
• (r-maint) Pass
• (r-run) Pass: I clicked around and found that the UI was indeed more navigable.
• (r-user) Pass: Overall UX improvement.
• (r-tech) Pass: No impact

[colemanw]

I'm recommending we merge this as it's an overall improvement. I do have one additional suggestion tho:

AFAIK there is no easy way to reach the "Option Groups" page (screenshot 1). In the menu you have to click Administer -> Customize Data & Screens -> Dropdown Options -> Gender and then go to the breadcrumbs and go up a level.
IMO we could fix this by turning the Dropdown Options menu leaf into a link (in the CiviCRM menubar, parent menu items are allowed to be links).

[eileenmcnaughton]

merging per label - yay @mattwire - merged