dev/core#256 - use unsigned int for temporary recipient ids

[rthouvenin]

Overview

This is to solve Gitlab issue 2⁸, which affects (seriously) CiviCRM users who have sent more than 2³¹ emails.

Before

When submitting an A/B mailing, the whole target group receives version A

After

When submitting an A/B mailing, only 50% of the sample group receives version A, the other half version B, and the rest is assigned to Final mailing.

Technical Details

The temporary table that holds recipient ids to move from mailing A to mailing B and C should use the column type int unsigned, which matches the one used by civicrm_mailing_recipients.

Comments

This is also a heads up that someone will hit 2³² emails sooner than later, and a number of columns should be migrated to BIGINT type at some point.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

@monishdeb i think this one might be for you to review as you have been in this code lately

[eileenmcnaughton]

So the advice is to use unsigned where there is no chance of a negative integer - https://stackoverflow.com/questions/11515594/when-should-i-use-unsigned-and-signed-int-in-mysql

this seems to be clearly the case here so I'm merging