Simplify input params on OptionValue::addOptionValue #12414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The addOptionValue function is one we should probably deprecate/ remove but towards that we should start to remove it. This commit removes some complexity by passing option_group_name rather than groupParams - which is a more accurate reflection of usage and removes ambiguity around the passing by reference
|
(Standard links)
|
|
test this please |
@eileenmcnaughton This is ok to merge - @monishdeb @seamuslee001 |
|
Merging as per Matt's testing |
|
thanks @mattwire |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Minor code simplification
Before
no change
After
code slightly simplified
Technical Details
The addOptionValue function is one we should probably deprecate/ remove but towards that we should start to remove it.
This commit removes some complexity by passing option_group_name rather than
groupParams - which is a more accurate reflection of usage and removes ambiguity around the passing
by reference
Comments
@mattwire can you review this one for me. I'm exploring extending the use of entity forms - but in this case I found something confusing so this is a preliminary clean up