Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core#227 Fix issue where on some extened groups the multiple reco… #12400

Merged
merged 1 commit into from
Jul 3, 2018

Conversation

seamuslee001
Copy link
Contributor

…rds checkbox doesn't show this causes empty string to be passed in which was causing problems when working out if we needed to make changes to the custom value table

Overview

When submitting the custom group setting form for custom groups extending activities the is_multiple checkbox doesn't show this causes an empty string to be passed through or is_multiple. This is replicated through the API. The test fails without the patch

Before

Hard fail when trying to edit the custom group settings for any custom groups extending activities

After

no hard fail

ping @eileenmcnaughton @monishdeb

…rds checkbox doesn't show this causes empty string to be passed in which was causing problems when working out if we needed to make changes to the custom value table
@civibot
Copy link

civibot bot commented Jul 3, 2018

(Standard links)

@eileenmcnaughton
Copy link
Contributor

Looks good to me - @jmcclelland ....

@seamuslee001
Copy link
Contributor Author

Merging as per the tag

@seamuslee001 seamuslee001 merged commit 713ff7e into civicrm:5.3 Jul 3, 2018
@jmcclelland
Copy link
Contributor

Just tested and it works for me. Thank you!

@eileenmcnaughton eileenmcnaughton deleted the dev_core_227 branch July 3, 2018 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants