(dev/core#174) APCcache - Updates to comply with PSR-16 #12381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One noteable quirk is that APC retains expired (per TTL) records until the following page-request. To comply with the test suite, we have to double-check the expiration time.
|
(Standard links)
|
| if ($default !== NULL) { | ||
| throw new \RuntimeException("FIXME: " . __CLASS__ . "::get() only supports NULL default"); | ||
| CRM_Utils_Cache::assertValidKey($key); | ||
| $result = apc_fetch($this->_prefix . $key, $success); |
There was a problem hiding this comment.
So I'm still under the impression that we will get e-notices sometimes if $success is not predefined - perhaps php versions are different on that?
|
I enabled APC cache & stepped through this & getting & setting looks to be working well. Changes make sense per related changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
#12342 provides nominal compliance with PSR-16; however, some drivers raise exceptions or warnings for new options.
(This is a cherry-pick from #12360.)
Before
$cache->set(...$ttl)would throw an error with any custom TTL.$cache->get(...$default)would throw an error for any not-NULL default.$cache->set()/$cache->get()handle objects in ways that are unsafe.After
APCcachehas been fixed to comply (per SimpleCacheTest), and a unit-test ensures compliance.Technical Details
One notable quirk is that APC retains expired records until the following page-request. To comply with the TTL semantics of the test suite, we have to double-store/double-check the expiration time.