dev/accessibility#3: Add accessible label on Contact Edit form elements and helpicon #12373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
Jenkins re test this please |
js/model/crm.uf.js
Outdated
| @@ -32,7 +32,8 @@ | |||
| * Add a help link to a form label | |||
| */ | |||
| function addHelp(title, options) { | |||
| return title + ' <a href="#" onclick=\'CRM.help("' + title + '", ' + JSON.stringify(options) + '); return false;\' title="' + ts('%1 Help', {1: title}) + '" class="helpicon"></a>'; | |||
| var title = ts('%1 Help', {1: title}); | |||
There was a problem hiding this comment.
@monishdeb just get rid of var here and that should fix the style issue.
monishdeb
force-pushed
the
access-3-contact-dash
branch
from
e2b8e71 to
c7915cc
Compare
|
This looks good to me. |
|
@monishdeb I'm curious to know why |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The PR adds aria-label attribute to all those form elements which don't have accessible labels and also adds this attribute on helpicon links
Before
Form elements like Website, Email, IM, Phone etc. don't have accessible labels and thus when tested with WAVE tool, let's say Website field:
After
Adds aria-label on form elements like Website, Email, IM, Phone etc.
