dev/core#195 Add Contribution Counts to Sub-tabs

[MiyaNoctem]

Overview

It would be helpful to be able to see on each sub-tab a count of Contributions / Recurring Contributions, keeping the UX consistent with how the rest of tabs work on Contact's Detail View.

Before

No counts were shown on Contribution sub-tabs.

After

Added counts to contribution sub-tabs.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

@MiyaNoctem do we also have a count available for inactive recur rows - if so it would be good to show them as well - I'm sure there is a precedent somewhere but I can't find it right now

e.g

{ts}Recurring Contributions{/ts} <em>{$activeRecurRows|@count}</em> {if $inactiveRecurRows} ({$inactiveRecurRows|@count}){/if}

gives

Which we could probably improve upon - but 'completed' recurring as at least as important as active recurring for most sites & the goal is to tell people whether to click on the tab

@colemanw @lcdservices

[eileenmcnaughton]

I'm going to merge this as I think it's 'better in than out' in the next rc but @MiyaNoctem @lcdservices I think we could go a bit further per above to also show completed