dev/core#187 Fix typo in CRM_Grant_Form_Task that prevents retrieving session key from URL

[mattwire]

Overview

Identified during investigation for dev/core#158

Before

Cannot retrieve session key for Grant form task.

After

Session key for Grant form task is retrieved just like all other tasks.

Technical Details

The wrong object was being used in static context ($this instead of $form).

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

@mattwire I agree with this change but we now have a new rule 'Alphanumeric' and we should use this instead of 'String' whereever possible (ie. when we only expect letters, numbers and underscore)

[mattwire]

I agree with this change but we now have a new rule 'Alphanumeric' and we should use this instead of 'String' whereever possible (ie. when we only expect letters, numbers and underscore)

@eileenmcnaughton Ok, but if we change it here we should really change it for all the other CRM_*_Task functions as well or this one will be different... Can we apply this PR as it is (as it's just a typo) and consider a separate PR to change it from String to Alphanumeric?

[eileenmcnaughton]

Ok @mattwire - I guess in principle 'whenever' we touch a 'String' we should try to change to Alphanumeric but I'm not digging in on this instance.

Also on reflection I think CRM_Core_Form should have a getter function for QFKey & we should use that anyway