Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup recordAdditionalPayment towards #11556 #12314

Conversation

mattwire
Copy link
Contributor

@mattwire mattwire commented Jun 15, 2018

Overview

Minor code tidy up, rename variable for clarity

Before

Code less easy to understand

After

Code easier to understand

Technical Details

This makes it clear that updateMembershipBasedOnCompletionOfContribution is only called from recordAdditionalPayment when contribution status = Completed

@eileenmcnaughton towards #11556

@civibot
Copy link

civibot bot commented Jun 15, 2018

(Standard links)

@eileenmcnaughton
Copy link
Contributor

I checked this change out & is sensible & correct

@eileenmcnaughton eileenmcnaughton merged commit 8bc8a91 into civicrm:master Jun 15, 2018
@mattwire mattwire deleted the CRM-21682_cleanup_recordAdditionalPayment branch September 25, 2018 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants