-
-
Notifications
You must be signed in to change notification settings - Fork 814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(dev/core#183) Temporary tables should follow consistent naming convention #12311
Commits on Jun 14, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 40c8b82 - Browse repository at this point
Copy the full SHA 40c8b82View commit details
Commits on Jun 15, 2018
-
(dev/core#183) Deprecate CRM_Core_DAO::createTempTableName()
We're changing the naming formula, but some use-cases may rely on the old naming formula. Anything based on the old formula needs to be examined.
Configuration menu - View commit details
-
Copy full SHA for 00f8d61 - Browse repository at this point
Copy the full SHA 00f8d61View commit details -
(dev/core#183) Change temp table naming for search-tasks
Testing notes - This is a pretty formulaic change. The main concern is some kind of typo or bad table name causing a hard-fail. To control that risk, we just run the code in a facile way: * Perform a contact search * Pick some contacts * Export them We do this procedure under a few circumstances: * With the original code * With a purposefully bad edit (provoking an expected error) * With the new code
Configuration menu - View commit details
-
Copy full SHA for c78f866 - Browse repository at this point
Copy the full SHA c78f866View commit details -
(dev/core#183) Change temp table naming for exports
Testing notes - This is a pretty formulaic change. The main concern is some kind of typo or bad table name causing a hard-fail. To control that risk, we just run the code in a facile way: * Perform a contact search * Pick some contacts * Export them * Run the export We do this procedure under a few circumstances: * With the original code * With a purposefully bad edit (provoking an expected error) * With the new code
Configuration menu - View commit details
-
Copy full SHA for 8e8b9e7 - Browse repository at this point
Copy the full SHA 8e8b9e7View commit details -
(dev/core#183) Change temp table naming for reports
Testing notes - This is a pretty formulaic change. The main concern is some kind of typo or bad table name causing a hard-fail. To control that risk, we just run the code in a facile way: * Navigate to "Reports => Contributions => Lybunt" * Add a "Filter" by "Group" We do this procedure under a few circumstances: * With the original code * With a purposefully bad edit (provoking an expected error) * With the new code In this commit, we changed two lines, so we do the above once for each line.
Configuration menu - View commit details
-
Copy full SHA for f7e48ba - Browse repository at this point
Copy the full SHA f7e48baView commit details -
(dev/core#183) Change temp table naming for CRM_Activity_BAO_Activity
Note: Verified that changes to this line are reflected as passes/failures in CRM_Activity_BAO_ActivityTest.
Configuration menu - View commit details
-
Copy full SHA for 33fa8c9 - Browse repository at this point
Copy the full SHA 33fa8c9View commit details -
(dev/core#183) Change temp table naming for CRM/Contact/Form/Search/C…
…ustom/ContribSYBNT.php Re:`r-run` -- Verified that these lines are executed by the search form -- and that the outcomes of a few basic searches are the same with the patch.
Configuration menu - View commit details
-
Copy full SHA for 6ec810c - Browse repository at this point
Copy the full SHA 6ec810cView commit details -
(dev/core#183) Change temp table naming for CRM/Contact/Form/Search/C…
…ustom/DateAdded.php Re:`r-run` -- Verified that these lines are executed by the search form -- and that the outcomes of a few basic searches are the same with the patch.
Configuration menu - View commit details
-
Copy full SHA for d3011c3 - Browse repository at this point
Copy the full SHA d3011c3View commit details
Commits on Jun 16, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 0038409 - Browse repository at this point
Copy the full SHA 0038409View commit details