Function extraction BAO_Export class #12288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
eileenmcnaughton
force-pushed
the
export
branch
2 times, most recently
from
953ef24
to
d7647f3
Compare
|
jenkins, test this please |
eileenmcnaughton
changed the title
eileenmcnaughton
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Extract a couple of functions as part of making code readable enough for #11870
Before
Functions not extracted
After
Functions extracted
Technical Details
I do get the goals / approach of #11870 but I can't get comfortable with it until I break down the code enough to make the change in a small way. @monishdeb wanna check this & merge - it's just an extraction & within that function there is a partial extraction
Comments