core/#170 minimal fix for fatal on soft_credit field

[eileenmcnaughton]

Overview

Contribution detail report errors when soft credits column is exposed

Before

Fatal if mode is contributions only & 'soft credits' box is selected

After

No fatal

Technical Details

We should get this merged & then
a) do a patch release drop for 5.2 with this
b) review a fix against master that actually adds unit testing #12281

Comments

@lcdservices can you test this & we'll get it merged / back ported and then can do some more thorough testing on #12280 - time to finally see this report get reliable

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[lcdservices]

@eileenmcnaughton tested and confirmed. No more errors and the soft credit data appears as expected.

[eileenmcnaughton]

OK - given merge-on-pass based on that testing - will backport & merge forwards once tests pass

[eileenmcnaughton]

test this please

[eileenmcnaughton]

test fail seems unrelated but odd

[monishdeb]

Test failure unrelated. Merging as per tag