Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'Alphanumeric' rule type #12258

Merged
merged 1 commit into from
Jun 5, 2018
Merged

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Jun 5, 2018

Overview

Add new validation function

Before

no change

After

no change

Technical Details

Added validation rule to support #12185 since that was slow in getting merged & I want to add another get param to another form. Pre-requisite for #12193

Comments

@seamuslee001 @colemanw can you merge this?

This type is now available when reading GET parameters with
`CRM_Utils_Request::retrieve()` and it offers improved security over the
widely used 'String' type by being strict enough to reject just about
any conceivable attack payload, while still accepting relatively simple
strings.
@civibot
Copy link

civibot bot commented Jun 5, 2018

(Standard links)

@seamuslee001
Copy link
Contributor

Agree with the changes all make sense added merge on pass

@seamuslee001
Copy link
Contributor

merging as per tag

@seamuslee001 seamuslee001 merged commit f59c376 into civicrm:master Jun 5, 2018
@eileenmcnaughton eileenmcnaughton deleted the alpha branch June 5, 2018 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants