CRM-20621 - Initial cleanup toward performance improvements #12256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@monishdeb can you review/merge this one? It is just a preliminary code cleanup before tackling the issue I noted in https://issues.civicrm.org/jira/browse/CRM-20621 |
|
Thanks, @colemanw for this cleanup. I tested the patch on the test build and found a difference when I compared with the tag tree w/o this patch where the reserved tag isn't marked with BEFORE
AFTER
|
|
Thanks @monishdeb for checking that. It was a typo in the css class. Now fixed. Please check again. |
|
Yup it worked. Merging as I tested the patch on test build and didn't found any unintended regression. Code improvements look great. |
|
test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minor code tidy-up which will result in a smaller payload being sent from the server to the jstree widget when managing tags. It removes empty values and unnecessary information from the json data.
Before
No change
After
No change