getCaseRoles not working when supplied relationship id. civicrm_relationship table name changed to alias name rel because its changed in the actual query #12245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s changed in the actual query but not in this extra Where condition
|
Can one of the admins verify this patch? |
sritechie26
changed the title
|
@civicrm-builder add to whitelist |
|
Looks sensible and safe to me. |
|
Merging as per tag |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This function call getCaseRoles($contactID, $case_id, $relationshipID); from Case.php file in \civicrm\CRM\Case\BAO location
CRM_Case_BAO_Case::getCaseRoles($contactID, $case_id, $relationshipID);
throwing error when passing $relationshipID. because actual query changed with alias name but one where condition is not changed with alias name. So updated with alias name to fix this issue.
Before
if ($relationshipID) {
$query .= ' AND civicrm_relationship.id = %3 ';
$params[3] = array($relationshipID, 'Integer');
}
After
if ($relationshipID) {
$query .= ' AND rel.id = %3 ';//Changed this alias name "rel" here
$params[3] = array($relationshipID, 'Integer');
}