dev/core/#152 - Remove AdvMulti-Select custom field type

[colemanw]

Overview

This widget type has been deprecated and this warning has been part of the UI since 2014. This PR finally removes it.

Before

The obsolete "AdvMulti-Select" widget was available as a custom field type, but the above warning would pop up when selecting it.

After

No longer available. Any custom fields using that type are changed to regular mutli-select (which uses Select2, a much nicer widget).

• https://lab.civicrm.org/dev/core/issues/152

[JoeMurray]

Thanks for doing this code maintenance, @colemanw . I have reviewed the code and it looks good but I have not tested.

[seamuslee001]

@colemanw is there any change to how the custom data is stored in the database for these fields that are getting converted?

[colemanw]

Nope.

[seamuslee001]

I have just run the upgrade on an AUG test box and have tested loading smart groups that were used with the old format and confirmed that no changes happen, I believe this is good for merge

[jitendrapurohit]

A quick grep after applying the PR -

$ grep -rn AdvMulti-Select CRM        
CRM/Upgrade/Incremental/sql/5.3.alpha1.mysql.tpl:18:UPDATE `civicrm_custom_field` set `html_type` = "Multi-Select" WHERE `html_type` = "AdvMulti-Select";
CRM/Contact/Import/Parser.php:910:          case 'AdvMulti-Select':
CRM/Contact/Import/Parser.php:1220:              case 'AdvMulti-Select':
CRM/Contribute/Form/Contribution/Confirm.php:650:              'AdvMulti-Select',

Should we remove the case added in Parser.php and Confirm.php too?

[eileenmcnaughton]

I'm going to merge this based on the review that has taken place (above) so that it hits the rc (since that is what the upgrade script applies to).

@colemanw do you want to look at a follow up PR per @jitendrapurohit comments?