dev/core#155 Improve Option Groups form #12233
Conversation
|
@mattwire this needs a rebase now? |
mattwire
force-pushed
the
optiongroup_form
branch
from
66c2902
to
4e3c8ef
Compare
mattwire
changed the title
mattwire
force-pushed
the
optiongroup_form
branch
from
4e3c8ef
to
3593e0f
Compare
|
I think this is Ok to merge - @yashodha maybe you could test this out in exchange for @mattwire testing #12367 - which seems similarly close to merging One question I have is whether 'anyone' can edit 'is_reserved' - I think for other entities it is a specifically permissioned change - perhaps we need to add a permission? (it would be nice if it were a little bit generic 'Administer reserved entities' or something - but that might be too hard. |
|
@mattwire Ok - so I just tested this & my concern about it giving extra permissions is unfounded - it just gives extra information - so I'm good to merge this. Looks like you did the review to trade with @yashodha but I got to this first so you might want to suggest another one @yashodha could review in exchange for the review you did on #12367 |
Overview
This adds Enabled/Reserved columns to list and puts buttons at the top as well.
Before
After
Technical Details
Just changes to the smarty template (and NFC code cleanup).
NOTE see #12235 for follow on