Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add api testing / custom data support for MailingJob. #12221

Merged
merged 1 commit into from
May 30, 2018
Merged

Add api testing / custom data support for MailingJob. #12221

merged 1 commit into from
May 30, 2018

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented May 28, 2018 •
edited by monishdeb
Loading

Overview

  1. Standardise Mailing Job api
  2. Add pre/post hooks to MailingJob::create()
  3. Replace all the DAO call with corresponding create fn in the codebase.

Before

SyntaxconformanceTests disabled for MailingJob entity

After

  1. SyntaxconformanceTests enabled for MailingJob entity
  2. Add pre/post hooks to MailingJob::create()
  3. Replace all the DAO call with corresponding create fn in the codebase.

Technical Details

There is no specific requirement for MailingJob to have custom data - but
this is generally part of standardising all entities to support custom
data (ie. workign through the list in
api_v3_SyntaxConformanceTest:toBeSkipped_custom_data_creatable
to remove the remaining rows.

Comments

@eileenmcnaughton
Copy link
Contributor Author

test this please

@eileenmcnaughton eileenmcnaughton force-pushed the api_extend_mailing_job branch 2 times, most recently from 593cec9 to 9a87d5b Compare May 29, 2018 22:27
@eileenmcnaughton eileenmcnaughton mentioned this pull request May 29, 2018
Closed
@eileenmcnaughton
Add api testing / custom data support for MailingJob.
f487e35 
There is no specific requirement for MailingJob to have custom data - but
this is generally part of standardising all entities to support custom
data (ie. workign through the list in
api_v3_SyntaxConformanceTest:toBeSkipped_custom_data_creatable
 to remove the remaining rows.

Fix some places to call create instead of saving mailing job to trigger hooks.
@eileenmcnaughton eileenmcnaughton force-pushed the api_extend_mailing_job branch from ea1290a to f487e35 Compare May 30, 2018 02:21
@monishdeb
Copy link
Member

Thanks @eileenmcnaughton

@monishdeb
Copy link
Member

Updated the description a bit :)

@monishdeb monishdeb merged commit 7f1a99f into civicrm:master May 30, 2018
@eileenmcnaughton eileenmcnaughton deleted the api_extend_mailing_job branch May 30, 2018 04:32
@eileenmcnaughton
Copy link
Contributor Author

Yep - since I brought in the hooks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eileenmcnaughton @monishdeb @civicrm-builder