CRM-21120 Add environment check for existence of mcrypt function #12215
Conversation
CRM-21120 Use a function-name agnostic test for encrypting powers CRM-21120 syntax error, missing semi-colon CRM-21120 Comma problems
|
@seamuslee001 I think you should treat this as a reviewer's commit & merge it yourself when you AND jenkins are happy |
|
test thie please |
|
Jenkins re test this please |
1 similar comment
|
Jenkins re test this please |
|
@seamuslee001 I think this might be an issue from the 5.2 merge to master I did PHP Fatal error: Cannot redeclare api_v3_ReportTemplateTest::testReportTemplateGetRowsAllReportsACL() in /home/jenkins/buildkit/build/core-12215-20gu9/sites/all/modules/civicrm/tests/phpunit/api/v3/ReportTemplateTest.php on line 230 |
|
Jenkins re test this please |
|
Merging as per Eileen's comment |
|
I realise that this is now closed, but only just saw this in the 5.3.0 release notes. Probably worth noting that the Mcrypt extension no longer exists as oh PHP 7.2 and was deprecated in 7.1; this alert rather than fixing an issue is damaging to the environments CiviCRM is hosted in. |
|
@agileware-fj Francis you can still get it from the PECL libraries iirc. https://github.com/civicrm/civicrm-buildkit/blob/master/bin/civi-download-tools#L467 |
|
That's correct, but doesn't change that it's been deprecated by PHP for reasonable reasons. Not worth going into it further here; I've opened issue dev/core#236 for an alternative suggestion.. |
|
I'd note that the warning is still useful, though the wording should now be adjusted. The warning was introduced to alert an administrator of the potential that a saved encrypted password would no longer work, because it couldn't be unencrypted, which is still true. |
Overview
This is a resubmit of #10918 by @adixon
Before
When Mcrypt extension isn't available no alert shown
After
Alert shown now when Mcrypt extension isn't available.
ping @eileenmcnaughton @totten @colemanw
To test this, check out the branch on a local buildkit build, Observe no warning message in the status checks. Edit the php that is used by the web server to disable mcrypt and restart web server. Observe that a warning now shows.