Code cleanup on export #12212
Merged
Code cleanup on export #12212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| $locTypeId = CRM_Utils_Array::value(2, $value); | ||
|
|
||
| if ($relationField) { |
There was a problem hiding this comment.
this chunk has been moved into the earlier loop as will be part of the same extraction
eileenmcnaughton
force-pushed
the
export_clean
branch
from
270aee1
to
41336a3
Compare
eileenmcnaughton
force-pushed
the
export_clean
branch
from
41336a3
to
b0eb1d7
Compare
|
test this please |
1 similar comment
|
test this please |
|
Tested this cleanup patch and it works when I tested on local, didn't cause any unintended regression. Added UT passed. |
This was referenced Jun 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This is preliminary code clean up. There is a complex (bug-fix) patch to this function that I don't feel comfortable reviewing with code cleanup first
Before
Code loops for different concerns intertwined
After
Code loops separated - ready for next commit to extract as a function the determination of relationship properties for a relationship ie
$returnPropertions[$relationshipType] = self:getReturnPropertiesForRelationshipType() should come out of next round. But extraction commits are best reviewed in isolation
Technical Details
@monishdeb still chipping away at this.... Can you review this chunk.
Comments