dev/accessiblity#3 Remove orphan label tag from Event pages #12209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@monishdeb could you fill in the template explaining this PR? Thx. |
|
sure @JoeMurray, actually this PR is not yet ready for review, reason why I have marked WIP in the title because there is a Event page where I got few more of these issues and will fix them all shortly. And I'll then update the template. |
|
Jenkins test this please |
monishdeb
changed the title
|
I feel like this change is limited to removing extraneous label tags (which are not common in our code) and the accessibility tool output clearly explains the reason. Merging |
|
Thanks @eileenmcnaughton :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR removes orphan labels, which means remove those labels which aren't associated with any control form elements.
Before
After