Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core#135 Fix first of 2 non numeric issues in CRM_Batch_form_entr… #12190

Merged
merged 1 commit into from
May 24, 2018

Conversation

seamuslee001
Copy link
Contributor

…yTest

Overview

This fixes a PHP7.1 issue where a non well formed numeric value is encountered

Before

Test fails on PHP7.1

PHPUnit 5.7.27 by Sebastian Bergmann and contributors.

.
Installing 47demotest_c6lz0 database
...E                                                               5 / 5 (100%)

Time: 37.54 seconds, Memory: 42.25MB

There was 1 error:

1) CRM_Batch_Form_EntryTest::testMembershipRenewalDates
A non well formed numeric value encountered

/home/seamus/buildkit/build/47.demo/sites/all/modules/civicrm/CRM/Batch/Form/Entry.php:721
/home/seamus/buildkit/build/47.demo/sites/all/modules/civicrm/CRM/Batch/Form/Entry.php:922
/home/seamus/buildkit/build/47.demo/sites/all/modules/civicrm/tests/phpunit/CRM/Batch/Form/EntryTest.php:256
/home/seamus/buildkit/build/47.demo/sites/all/modules/civicrm/tests/phpunit/CiviTest/CiviUnitTestCase.php:192
/home/seamus/buildkit/bin/phpunit5:598

ERRORS!
Tests: 5, Assertions: 143, Errors: 1.

After

Test still fails on PHP7.1 but at a later point in the batch process on another non well formed numeric value

ping @eileenmcnaughton @monishdeb

@eileenmcnaughton
Copy link
Contributor

lol

Seems fine

@seamuslee001
Copy link
Contributor Author

Merging as per tag

@seamuslee001 seamuslee001 merged commit a96624f into civicrm:master May 24, 2018
@seamuslee001 seamuslee001 deleted the dev_ore_135_a branch May 24, 2018 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants