dev/core#43 - Update geocoding setting text to reflect need for Google API key #12188
Conversation
|
Can one of the admins verify this patch? |
|
Jenkins test this please |
|
@larssg-wildsight this makes sense I think the big picture is we really want geocoding to be an extension service, not a core service - ie. ideally this would replace having a geocoder in core at all https://github.com/eileenmcnaughton/org.wikimedia.geocoder But, I think this should be merged as it DOES improve the help text accuracy |
|
I just noticed this doesn't really make sense "You may choose a different webservice for geocoding or select the same service." |
| @@ -2313,7 +2313,7 @@ function setting_getfields_expectedresult() { | |||
| ), | |||
| 'default' => '', | |||
| 'title' => 'Geocoding Provider', | |||
| 'description' => 'You may choose a different webservice for geocoding. This is required if there is no geo-coding plugin for your selected mapping provider. You can leave the Geocoding fields blank if you are using Google as your mapping provider.', | |||
| 'description' => 'You may choose a different webservice for geocoding or select the same service.', | |||
There was a problem hiding this comment.
Maybe change to 'or select the same service as you use for Map Provider.'
| @@ -72,7 +72,7 @@ | |||
| ), | |||
| 'default' => NULL, | |||
| 'title' => 'Geocoding Provider', | |||
| 'description' => 'You may choose a different webservice for geocoding. This is required if there is no geo-coding plugin for your selected mapping provider. You can leave the Geocoding fields blank if you are using Google as your mapping provider.', | |||
| 'description' => 'You may choose a different webservice for geocoding or select the same service.', | |||
There was a problem hiding this comment.
Maybe change to 'or select the same service as you use for Map Provider.'
| </tr> | ||
| <tr class="crm-map-form-block-geoProvider"> | ||
| <td>{$form.geoProvider.label}</td> | ||
| <td>{$form.geoProvider.html}<br /> | ||
| <span class="description">{ts}You may choose a different webservice for geocoding. This is required if there is no geo-coding plugin for your selected mapping provider. You can leave the Geocoding fields blank if you are using Google as your mapping provider.{/ts}</span></td> | ||
| <span class="description">{ts}You may choose a different webservice for geocoding or select the same service.{/ts}</span></td> |
There was a problem hiding this comment.
Maybe change to 'or select the same service as you use for Map Provider.'
|
Good point! I've updated to this: This can be the same or different from the mapping provider selected. which I hope is clear. Here: #12232 |
Overview
The explanatory text on the geocoding settings page indicates that Google doesn't need an API key, but geocoding will no longer work without an API key. Also, the text says you do not need to enter a Geocoding provider if you are using Google as your mapping provider, but this is no longer true.
Before
Also the same in the Map Provider Key and Mapping Provider descriptions in the API.
After
To come.