[NFC] code changes for export with merge household #12177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I am working through https://github.com/civicrm/civicrm-core/pull/11870/files & this is one very minor change that makes sense to commit in isolation
eileenmcnaughton
force-pushed
the
test_monish
branch
from
9388dd1 to
f0d5835
Compare
eileenmcnaughton
changed the title
|
Jenkins re test this please |
|
test this please |
|
jenkins, test this please |
|
test this please |
1 similar comment
|
test this please |
|
Tested it on local and its safe to merge, doesn't break the workflow. From code pov it makes sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Minor code tidy ups
Before
No change
After
No change
Technical Details
Changes one variable to be named earlier & stops passing two variables that can be retrieved at no code due to caching in the called function
Comments
I'm trying to work through #11870 & these are 2 minor changes en route to making sense of that (one of them is in that PR already & the other is my own). @monishdeb can you check this & merge.
That code is hurting my head :-(