dev/core#124 Enhancements for events requiring approval

[aydun]

Overview

For events requiring approval:

1. Avoid warning on confirmation page
2. Improve subject line on pre-approval email
3. Remove fees section on pre-approval email (fees have not been selected yet at this stage)

Before

Create an event requiring approvals, and with fees.
Register for the event.
Observe:

1. On the confirmation screen, a warning Warning: A non-numeric value encountered in XXX/civicrm/CRM/Event/Form/Registration/Confirm.php on line 262
2. The email received after the initial registration (ie pre-approval) has subject 'Registration Confirmation' - although the registration is not yet confirmed
3. The same email has a Fees section showing a total of 0 - which is misleading since costs are involved but have not been selected at this stage.

After

Create event and register as previously.
Observe:

1. No warning on the confirmation screen
2. Pre-approval mail has subject 'Registration Request Confirmation'
3. No Fees section

Technical Details

none

Comments

none

[seamuslee001]

@aydun Aiden, as your changing the receipt templates i think we will need an upgrade step to upgrade the templates i think

[aydun]

@seamuslee001 You're right ... what directory do I need to create under CRM/Upgrade/ ? 5.3.msg_template?

[eileenmcnaughton]

Once this is merged the message template update should be easier

#12224

[eileenmcnaughton]

I tested this out & when manually updated the template changes make sense as does the php change

@aydun you will need to follow this up with a patch to add these templates (or at least the subject one) to the templates to be updated. (since I think the other 2 are already caught up once #12296 is merged. @seamuslee001 any chance you can look at #12296 since it needs merging before the last step on this one can be sorted

[aydun]

See #12417 for follow-up