Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing UK state #12138

Closed
wants to merge 1 commit into from
Closed

missing UK state #12138

wants to merge 1 commit into from

Conversation

applicado
Copy link
Contributor

Monmouthshire is in Wales

Overview

A brief description of the pull request. Try to keep it non-technical.

Before

The current status. Please provide screenshots or gifs (LICEcap, SilentCast) where appropriate.

After

What has been changed. Please provide screenshots or gifs (LICEcap, SilentCast) where appropriate.

Technical Details

If the PR introduces noteworthy technical changes, please describe them here. Provide code snippets if necessary

Comments

Anything else you would like the reviewer to note

Monmouthshire is in Wales
@civicrm-builder
Copy link

Can one of the admins verify this patch?

@seamuslee001
Copy link
Contributor

Hi @applicado thank you so much for submitting this PR, There is one piece of additional work that needs to be done

Could you please edit the file CRM/Upgrade/Incremental/sql/5.3.alpha1.mysql.tpl in a similar way to this file https://github.com/civicrm/civicrm-core/blob/master/CRM/Upgrade/Incremental/sql/4.7.32.mysql.tpl#L3 but for your change. That way then existing sites will get the new state province as well

ping @mlutfy

@mlutfy
Copy link
Member

mlutfy commented May 19, 2018

Closing in favour of #12168

@mlutfy mlutfy closed this May 19, 2018
@eileenmcnaughton
Copy link
Contributor

thanks @seamuslee001 for following through on this with the upgrade-fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants