Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(dev/core/98) Searching by any Address fields with location type other than primary throw DB error #12081

Merged
merged 1 commit into from
May 6, 2018

Conversation

monishdeb
Copy link
Member

Overview

Steps to replicate:

  1. Go to Search Builder
  2. Choose Contact >> Street Address (or any address field) >> Home (as location type) >> NOT EMPTY (or any other operator)
  3. Submit
    See the result under BEFORE

Before

test-multiple-before

After

test-multiple-after

Technical Details

I would say this is a regression due to this change fbbd2be#diff-e54381bfdf51e31cab376c71ca0d66ffR4895
The change was earlier made to fix FGB error as per which SELECT columns must have all those column(s) that are present in GROUP BY clause. But in certain case, we only want a predefined set of (formatted) column like in this case UPPER(LEFT(contact_a.sort_name, 1)) as sort_name irrespective of what's there in GROUP BY, we need to disable FGB to allow such query to pass.

@eileenmcnaughton
Copy link
Contributor

Merging this backport to the rc as discussed on #12074

@eileenmcnaughton eileenmcnaughton merged commit 6dc551c into civicrm:5.2 May 6, 2018
@monishdeb monishdeb deleted the dev_core_98_52rc branch May 8, 2018 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants