pass mailingJobId to hook_tokenValues

[michaelmcandrew]

Overview

Fixes bug where mailing job id was not passed to CRM_Utils_Hook::tokenValues().

Before

Flexmailer sets mailingJobId as context for the token in DefaultComposer::createTokenRowContext() TokenCompatSubscriber::onEvaluate() should pick up the mailingJobId and pass it on to CRM_Utils_Hook::tokenValues(), however, there is a typo on the code that prevents it passed on.

After

This PR fixes the typo so that the ID is passed on correctly.

Comments

I git blamed through Civi/Token/TokenCompatSubscriber.php and this appears to be a typo that was not picked up yet since no one has any code that relies on the presence of mailingJobId in the token values hook (until now).

At the same time, I am wondering how to be sure that TokenCompatSubscriber::onEvaluate() is not called by some other process that is passing a MailingJob object as the context. I don't think so, and my logic is as follows:

• onEvaluate is registered as listening to \Civi\Token\Events::TOKEN_EVALUATE
• the only place this event is dispatched is in \Civi\Token\TokenProcessor::evaluate()
• evaluate() is only called in one other place apart from TokenCompatSubscriber::onEvaluate(): CRM_Core_BAO_ActionSchedule and mailingJob is not set/relevant here

But maybe I missed something.

[seamuslee001]

ping @totten

[eileenmcnaughton]

@totten this appears to be just a fix for a typo of yours but not really comfortable merging without your check

[michaelmcandrew]

@totten - ping again :)

[eileenmcnaughton]

I'm gonna merge this - when the original submitter comes back to a minor code change after a long spell and still thinks it is correct I think they can qualify as an independent reviewer. This seems pretty minor & clear cut & safe from what I can see & we can't clone @totten so we have to work within the tottens we have

[michaelmcandrew]

thanks @eileenmcnaughton - i kind of regretted adding another ping @totten to the see of ping @tottens after I had done it since, yes, we do have to find a way to expand the tims. I'll be more imaginative next time :)