core/issues/64 - In custom searches, column headings are being ignored

[jitendrapurohit]

Overview

Fix for column headers missing from almost all custom searches. Some of them are also missing the entire columns.

Before

Screenshot of Postal mailing custom search.

After

Technical Details

If $value is not set, getModeValue() will set the default selector to CRM_Contact_Selector which is then considered to display column headers and $sort criteria on the result page.

Comments

Regression from eda34f9#diff-32fdf98c87aec5fc49db16d49ab1fabb

---

Gitlab issue - https://lab.civicrm.org/dev/core/issues/64

[eileenmcnaughton]

I just tested this & agree I could replicate the bug & that this fixes it - merging

@mattwire FYI - regression from #11600

[mattwire]

Right, so this fix is just masking a deeper issue as $taskClassName::getTask() is exactly the same as calling CRM_Contact_Task::getTask().

The issue is actually in CRM_Contact_Form_Search::setModeValues as it's a static and self::$_selectorName changes after being called.