Fix fatal error when selecting a $0 price option in change fee selection #11934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code for creating a new price option creates a new financial transaction but when choosing a /bin/bash price option it fails as the api does not accept /bin/bash EntityFinancialTrxn, skip if /bin/bash
|
@eileenmcnaughton here's my screencast where I was unable to replicate the issue: Did I miss something? |
|
here is what I see |
|
@monishdeb I've switched to master - feel like we should get it into 5.1 rc but not aim for 5.0. |
|
Able to replicate the issue and it correctly fixes the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fix fatal error when changing event fee selection from a price option with a fee to a $0 option
Before
Fatal error if I change option from tiny tots to 'none' in the first field
After
Fatal error gone
Technical Details
The code for creating a new price option creates a new financial transaction but when choosing a $0 price option it fails as the api does not accept $0. Skip creation if $0
Comments
@monishdeb I think we probably should push this into the rc - was trying to replicate CRM-17267 & hit this