Fix fatal on topDonor report #11919
Merged
Fix fatal on topDonor report #11919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@eileenmcnaughton : Top report yeilds results as expected, add to group also work fine. |
|
test fail unrelated. Merging based on @yashodha testing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fix fatal error when loading the topDonor report
Before
Fatal error
After
No fatal error
Technical Details
This is the same underlying issue as #11917 - ie. the way in which the total amount field was getting into the full groupBy was by accident rather than by design.
I have made it possible to add 'required' 'no_display' group fields. Note the the 'large change' is just the removal of an 'if' so it iterates through looking for required fields.
Comments
There was an test on the report instances that was previously disabled for this report as it fatalled but with this patch I am able to stop skipping it.
I also quashed the groupBys on the address fields as they don't work & were not added intentionally. The order bys don't work either but that seems older and does not just affect address fields.
@yashodha this is the bug you found