Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRM_Utils_Rule - Fix typo in checkExtesnionKeyIsValid #11888

Merged
merged 1 commit into from
Mar 28, 2018

Conversation

mattwire
Copy link
Contributor

Overview

checkExtesnionKeyIsValid -> checkExtensionKeyIsValid

@eileenmcnaughton
Copy link
Contributor

test this please

@eileenmcnaughton
Copy link
Contributor

I grepped & these are the only 3 places 'Extesnion' is found

@seamuslee001 seamuslee001 merged commit 0883b81 into civicrm:master Mar 28, 2018
@totten
Copy link
Member

totten commented Mar 28, 2018

I agree this is a good/safe fix. Nice job on quickly handling simple problem.

We can do better in terms of r-explain. When I first read, "NFC Fix function name typo", that struck me as a non-sequitur -- renaming a function is a prima facie change in a contract, which is prima facie functional, therefore not NFC. As someone skimming the changelog, the message just confuses me.

Suggested commit-message/PR title:

CRM_Utils_Rule - Fix typo. Rename checkExtesnionKeyIsValid to checkExtensionKeyIsValid.

or maybe:

CRM_Utils_Rule - Fix typo in checkExtesnionKeyIsValid

@totten totten changed the title NFC Fix function name typo CRM_Utils_Rule - Fix typo. Rename checkExtesnionKeyIsValid to checkExtensionKeyIsValid. Mar 28, 2018
@totten totten changed the title CRM_Utils_Rule - Fix typo. Rename checkExtesnionKeyIsValid to checkExtensionKeyIsValid. CRM_Utils_Rule - Fix typo in checkExtesnionKeyIsValid Mar 28, 2018
@mattwire mattwire deleted the formrule_typo branch September 25, 2018 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants