CRM-21791 Use name for comparison instead of label (alternative) #11878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -117,7 +117,7 @@ public function buildQuickForm() { | |||
| $batchStatus = CRM_Core_PseudoConstant::get('CRM_Batch_DAO_Batch', 'status_id'); | |||
|
|
|||
| // unset exported status | |||
| $exportedStatusId = CRM_Utils_Array::key('Exported', $batchStatus); | |||
| $exportedStatusId = CRM_Core_PseudoConstant::getKey('CRM_Batch_DAO_Batch', 'status_id', 'Exported'); | |||
There was a problem hiding this comment.
As a general practice we should use 'BAO' rather than 'DAO' in case there is an override (you don't need to change the PR just for this but if you are changing the PR BAO is preferred)
|
test this please |
|
Changes look good - seems mergeable pending feedback from @samuelsov |
mattwire
force-pushed
the
CRM-21791_financial_batch_pseudoconstant
branch
from
95297cc to
b9a4cb6
Compare
|
Ok thanks, will test this today. |
|
Yes, it solves the problem, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This is an alternative to #11710 which converts everything in the class.
Code needs testing @samuelsov does this work?