Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NFC] remove unused vars #11874

Merged
merged 1 commit into from
Mar 26, 2018
Merged

[NFC] remove unused vars #11874

merged 1 commit into from
Mar 26, 2018

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Minor code clean up - $countryDefault & $attributes are not used

@seancolsen
Copy link
Contributor

(CiviCRM Review Template WORD-1.1)

  • (r-explain) PASS
  • (r-test) PASS
  • (r-code) PASS
  • (r-doc) PASS
  • (r-maint) PASS
  • (r-run) PASS
    • I didn't run it. But I did look at this code with PhpStorm which verified that all of these variables were unused. Changes look clear.
  • (r-user) PASS
  • (r-tech) PASS

Hooray for removing code!

Ping @colemanw @totten for merging.

@seamuslee001 seamuslee001 merged commit 5fdd105 into civicrm:master Mar 26, 2018
@eileenmcnaughton eileenmcnaughton deleted the cust_data branch March 27, 2018 00:07
@eileenmcnaughton
Copy link
Contributor Author

Thanks @seanmadsen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eileenmcnaughton @seancolsen @seamuslee001 @civicrm-builder