Fix bugs with hook params, functionality on contact searches #11861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…M-21841 as by-product. The self::objectType is passing NULL - the object type on the parent. Switching to static::objectType uses the child. https://stackoverflow.com/questions/1912902/what-exactly-are-late-static-bindings-in-php
This was picked up in QA on search task changes & I was able to replicate - this fixes
eileenmcnaughton
changed the title
|
Tested - I was about to submit the same fix for static::objectType. Maybe also git rid of the declaration at line 73 since it is now not used. |
|
I'm merging this based on @aydun testing / concurrence. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fix issue with entity not passed to hook (also fixes CRM-21841 ).
Fix tangental issue where screen does not load if default task is removed per #11596 (comment)
Before
$objectType Not passed to hook civicrm_searchTasks
After
$objectType passed to hook civicrm_searchTasks
Technical Details
The self::objectType is passing NULL - the object type on the parent.
Switching to static::objectType uses the child.
https://stackoverflow.com/questions/1912902/what-exactly-are-late-static-bindings-in-php
Comments
@mattwire ping