Consolidate CustomData code into shared tpl

[eileenmcnaughton]

Overview

There is a lot of code replication rendering custom data fields. In preparation for exposing for more entities I am consolidating the template files

Before

After

No change - but adding screenshots to show...

Technical Details

The only change that I found in function was that the delete icon was originally in a
table on contact edit but afterwards it was not. However the UI looked the same - ie the table in got stripped - this shows up when using the contact edit form & there is a delete icon - ie the below is 'after'

-          <table class="no-border">
-            <tr>
-              <a href="#" class="crm-hover-button crm-custom-value-del" title="{ts 1=$cd_edit.title}Delete %1{/ts}"
-               data-post='{ldelim}"valueID": "{$tableID}", "groupID": "{$group_id}", "contactId": "{$contactId}", "key": "{crmKey name='civicrm/ajax/customvalue'}"{rdelim}'>
-                <span class="icon delete-icon"></span> {ts}Delete{/ts}
-              </a>
-              <!-- crm-submit-buttons -->
-            </tr>
-          </table>

Comments

@jitendrapurohit @mattwire ping

[eileenmcnaughton]

test this please

[jitendrapurohit]

Loaded multiple pages and looks fine w.r.t display on Advanced Search and contact summary page. While testing, I found some issues after applying this patch -

• Delete action doesn't work for multi-valued custom field. To replicate - add a multi-valued custom field for Contacts and display it Inline. Try to delete a custom value from Edit Contact link and save the Form. The field value is displayed as it is on the contact summary page.

• Another <set name> record link incorrectly shown for multi-valued custom field displayed as Tab with Table. To replicate - change the above set to display as Tab with table.

  • Navigate to the contact summary page -> Custom field tab and try to add a value.
  • A link is displayed on the bottom of the page Another <set name> record which I think is meant for Inline display and should not be shown here.

[eileenmcnaughton]

Thanks @jitendrapurohit ! I've just pushed a fix for the delete issue - am looking at the other points now

[eileenmcnaughton]

@jitendrapurohit I found & fixed the second of those items too

[jitendrapurohit]

Both the listed issues seems to be fixed 👍. Don't see any more issues with the PR.