Dev/Core 25 Wrap the mailing split_job function in a transaction to e… #11836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@seamuslee001 just spotted this https://github.com/seamuslee001/civicrm-core/blob/e28651449ece0fdce25069c523b0aa8810c3e1a7/CRM/Mailing/BAO/MailingJob.php#L381 - just need to move that up one line & the existing transaction can wrap it all |
…nsure that there is no possibility of duplicate maiing jobs created Include the split_jobs in the transaction used to update the parent job
seamuslee001
force-pushed
the
dev_core_25
branch
from
e286514
to
2cf4876
Compare
|
@eileenmcnaughton have done so now |
|
I think this is now limited enough we can proceed to merge it once tests pass |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nsure that there is no possibility of duplicate maiing jobs created
Overview
AUG ran into an issue where the split_job function was being run but subsequent process mailing jobs started processing the child jobs causing locks on the table which then created duplicate child jobs for the mailing. The aim of this is by wrapping it in a transaction other processes won't be able to block it / any errors will trigger a roll back.
ping @eileenmcnaughton @monishdeb would one of you be able to review this please?