Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix template in pledge and batch #11818

Merged

Conversation

mukeshcompucorp
Copy link
Contributor

Overview

This PR

  • adds label tag as per other tables and forms in batch
  • Separates contact detail icon from contact based on other search and table pages.

Before

image

After

image

Comments

This changes are done with BackstopJS test so, there is not page breaking due to this

@colemanw
Copy link
Member

There seems to be an inconsistency with the number of columns vs headers if $single == TRUE. Can you explain what's going on there @mukeshcompucorp ?

@mukeshcompucorp
Copy link
Contributor Author

Ok so basically old logic is

{if $single}
  <th></th>
{/if}

Now I wanted to add one extra th for extra td below.

{if !$single}
  <td>{$row.contact_type}</td>
{/if}

so, I would need,

{if !$single}
  <th></th>
{/if}

which makes basically, my code,

{if $single}
  <th></th>
{/if}
{if !$single}
  <th></th>
{/if}

Which you can say just counter conditions? so, I removed it. does it makes sense?

@colemanw
Copy link
Member

Ok. Makes sense now.

@colemanw colemanw merged commit cbb0d22 into civicrm:master Mar 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants