Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix html template structure with classes, divs & tags #11796

Merged

Conversation

mukeshcompucorp
Copy link
Contributor

Overview

This PR

  • adds approripate classes and tags
  • makes indentation proper

Screenshots

No Visual Changes

@eileenmcnaughton eileenmcnaughton changed the title Fix template structure Fix html template structure WRT classes & tags Mar 11, 2018
@eileenmcnaughton eileenmcnaughton changed the title Fix html template structure WRT classes & tags Fix html template structure WRT classes, divs & tags Mar 11, 2018
@colemanw
Copy link
Member

@mukeshcompucorp that's odd - the diff makes a reference to shoreditch.?

@mukeshcompucorp
Copy link
Contributor Author

Not all though, I'm just preserving standardization when something is not right and I have a template file open I fix it.

@colemanw
Copy link
Member

colemanw commented Mar 12, 2018

@mukeshcompucorp click over to the "Files Changed" tab in this PR. There is a reference to Submodule org.civicrm.shoreditch added at ea48cd I don't know what that means but it isn't just template changes.

@mukeshcompucorp
Copy link
Contributor Author

@colemanw thanks, wrong commit I will amend and let you know

@mukeshcompucorp
Copy link
Contributor Author

@colemanw Fixed the commit now

@mukeshcompucorp mukeshcompucorp changed the title Fix html template structure WRT classes, divs & tags Fix html template structure with classes, divs & tags Mar 13, 2018
@colemanw colemanw merged commit b4c2cdd into civicrm:master Mar 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants