dev/financial/5 If a currency has been disabled allow the form to be submitted

[mattwire]

See https://lab.civicrm.org/dev/financial/issues/5

Overview

If you have contributions / recurring contributions in a specific currency and subsequently disable that currency in CiviCRM settings it is no longer possible to submit forms with an "amount" element that add the currency as a frozen value (eg. recurring contribution updateSubscription).

Before

Cannot submit form.

After

Form can be submitted, record can be updated. A warning is written to the log warning that the currency is disabled but still in use.

[eileenmcnaughton]

test this please

[eileenmcnaughton]

Hmm - this is pretty obscure but will some mucking around I could replicate it & I don't see a downside with this fix even if it feels like an odd thing to be handling

[adixon]

FWIW - the issue with this fix is that it doesn't anticipate that the function would be called without a default currency, generating confusing warnings in the log. Fixed here:
91a3322
I think this addCurrency function has still got some issues, though.