Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRM-21830: Add 'state_province_name' token and set appropriate value … #11776

Conversation

vinuvarshith
Copy link
Contributor

…to it so that it is not empty for billing address

Overview

When 'state_province_name' token is used(in address settings), the state/province is empty when 'Billing Address' is displayed(example, during Event registration on confirmation page)

Before

Using state_province_name in address settings gave empty results when displaying billing address.
image-2018-03-01-10-35-12-231

After

Billing addresses now displays state_province_name token as expected

…to it so that it is not empty for billing address
@civicrm-builder
Copy link

Can one of the admins verify this patch?

@seamuslee001
Copy link
Contributor

Jenkins test this please

@mattwire
Copy link
Contributor

mattwire commented Mar 8, 2018

Code looks good and will be useful for UK addresses which normally show the full name rather than an abbreviation.

@colemanw
Copy link
Member

colemanw commented Mar 9, 2018

@mattwire if you have a minute to r-run this and test it out on your sandbox, I can go ahead and merge it when you give the 👍

@ejegg
Copy link
Contributor

ejegg commented Mar 9, 2018

+1 This works great on my dev instance, both for mailing labels and on-screen display.

@eileenmcnaughton
Copy link
Contributor

Merging since this appears to have been only pending r-run which @ejegg did

@eileenmcnaughton eileenmcnaughton merged commit 5dde2c0 into civicrm:master Mar 11, 2018
@colemanw
Copy link
Member

@seamuslee001 @mattwire can either of you confirm that this works in practice?

@eileenmcnaughton
Copy link
Contributor

@colemanw I think @ejegg did that

@colemanw
Copy link
Member

Ok thanks @eileenmcnaughton

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants