[REGRESSION] CRM-21806: Fix issues is search form when FULL_GROUP_BY_MODE enabled #11769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monishdeb
changed the title
|
@eileenmcnaughton can we get this PR merged before 4.7.32-rc cut? |
|
This passes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR fixes the issues encountered after #11746 merge on Advanced Search and Custom search forms when
FULL_GROUP_BY_MODEis enabled, those are listed under Before sectionBefore
unknown column civicrm_address.id:After
Technical Details
Thanks to the fix made here it now exposes any query failure while populating entries in prevnext table.