CRM-21391 Convert Member to use core Task class #11762
Conversation
| $form->assign('taskName', $memberTasks[$form->_task]); | ||
| $tasks = CRM_Member_Task::permissionedTaskTitles(CRM_Core_Permission::getPermission()); | ||
| if (!array_key_exists($form->_task, $tasks)) { | ||
| CRM_Core_Error::statusBounce(ts('You do not have permission to access this page.')); |
There was a problem hiding this comment.
I feel a little nervous about this standardisation - does this bounce happen BEFORE or AFTER hooks get to 'add their say'
There was a problem hiding this comment.
@eileenmcnaughton This has been standardised across all tasks. Previously I think some did this, some did not. It is on the form layer AFTER hooks have run (the searchTasks hook gets run via permissionedTaskTitles in this case so you are only likely to get here with an invalid task ID if you've manipulated a URL or done something else weird - it was then somewhat undefined as to what would happen, a task might load or you might get a fatal.
|
I UI tested this & it seems good. Code looks good & has been previously agreed as an improvement. Merging |
Overview
Refactor member task form to use base class
Before
After
Technical Details
details in #11240
Comments
This is a commit from #11240
In terms of review check that the code was a positive improvement and tested a couple of actions as well as checking the same number of actions were present