Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRM-21815 - re-opening a civicase - Case Coordinator (and other roles… #11736

Merged
merged 1 commit into from
Jun 11, 2018

Conversation

jitendrapurohit
Copy link
Contributor

@jitendrapurohit jitendrapurohit commented Feb 28, 2018

…) are not reinstated

Overview

On re-opening a civicase - Case Coordinator (and other roles) are not reinstated

Before

SE question - https://civicrm.stackexchange.com/questions/22932/if-a-civicase-is-reopened-why-isnt-the-case-coordinator-and-other-roles-reins

Check Jira issue for replicating it.

After

End date of Case relationship is set to NULL which displays case roles in Active section.

Technical Details

getCaseRoles function seems to be returning only active relationships, but if a case status is changed from Resolved to Ongoing, this function should be able to return all relationship to make them active again.

Comments

Added unit test.


@eileenmcnaughton
Copy link
Contributor

@colemanw @monishdeb @lcdservices @guanhuan - this looks like it is review-ready. Anyone prepared to pick it up?

@lcdservices
Copy link
Contributor

@eileenmcnaughton I tested the patch.

  1. opened a new case. confirmed there were roles set.
  2. changed the case status to resolved. confirmed the case role was no longer active.
  3. changed the case status base to opened. the case role was restored/activated.

Looks good to me. And I agree with the behavior.

@colemanw
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants