Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRM-21814: Fixed text wrapping #11735

Conversation

mukeshcompucorp
Copy link
Contributor

@mukeshcompucorp mukeshcompucorp commented Feb 28, 2018

Overview

This PR adds wrapper to tangling text without any wrapper in event configure tabs

Screenshots

No Visual Change for now, it will be effective in future if styling is handled


@colemanw
Copy link
Member

colemanw commented Mar 1, 2018

The css class "description" has always been problematic, as it conflicts with many CMS themes, notably Drupal. It's beyond the scope of this PR but FYI, I think it ought to be "crm-description".

@colemanw colemanw merged commit 748ad23 into civicrm:master Mar 1, 2018
@mukeshcompucorp
Copy link
Contributor Author

Thanks @colemanw , It's good to know, though, for now, I'm working to make things consistent across all the screens. once, we have consistency, let say, all things are with class description, we can discuss this with core team and then change all place to have crm-description, that will make more sense and will be properly maintained as well.

@mlutfy mlutfy added this to the 4.7.32 milestone Mar 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants