Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(NFC) Rename fiterable fields param in _civicrm_api3_basic_array_get … #11711

Merged
merged 1 commit into from
Feb 22, 2018

Conversation

seamuslee001
Copy link
Contributor

…to be more explicit about what it is for

Overview

This just renames a variable to be more explicit about what it accomplishes. This was found to be problematic through the work on the Extension API

ping @totten @eileenmcnaughton this should be very straight forward and should help in the future

@totten
Copy link
Member

totten commented Feb 22, 2018

(CiviCRM Review Template WORD-1.0)

  • (r-jira) Waive: Very small change. No benefit to extra process.
  • (r-test) Undecided: Tests haven't finished running yet
  • (r-code) Pass: Seems like an improvement in readability. Hopefully prevents misunderstandings.
  • (r-doc) Pass
  • (r-maint) Pass
  • (r-run) Pass: There's really no UI/use-case. This is a utility function, and it has pretty good direct+indirect test-coverage.
  • (r-user) Pass
  • (r-tech) Pass: Renames a local variable, which should only impact code within one function. Examined the function to confirm that it was renamed consistently.

@seamuslee001
Copy link
Contributor Author

This has passed tests now @eileenmcnaughton @totten

@totten totten merged commit 662a746 into civicrm:master Feb 22, 2018
@seamuslee001 seamuslee001 deleted the variable_rename_filter_fields branch February 22, 2018 23:39
@mlutfy mlutfy added this to the 4.7.32 milestone Mar 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants